RFR: 8310978: JFR events SocketReadEvent/SocketWriteEvent for Socket adaptor ops [v3]

Daniel Fuchs dfuchs at openjdk.org
Thu Oct 26 10:36:36 UTC 2023


On Wed, 25 Oct 2023 21:43:54 GMT, Tim Prinzing <tprinzing at openjdk.org> wrote:

>> Added jar event support to socket adapters.
>> 
>> Added the test jdk/jfr/event/io/TestSocketAdapterEvents.java
>
> Tim Prinzing has updated the pull request incrementally with one additional commit since the last revision:
> 
>   changes from review:
>   
>   - use loopback address
>   - fetch timeout once
>   - formatting improvements

Looks good to me. I like the use of `offer` to reduce the boiler-plate code, when acquiring the event parameters doesn't cause any allocation and just return some field value.

-------------

Marked as reviewed by dfuchs (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16251#pullrequestreview-1699265942


More information about the nio-dev mailing list