RFR: 8310978: JFR events SocketReadEvent/SocketWriteEvent for Socket adaptor ops [v3]

Alan Bateman alanb at openjdk.org
Thu Oct 26 10:39:35 UTC 2023


On Wed, 25 Oct 2023 21:43:54 GMT, Tim Prinzing <tprinzing at openjdk.org> wrote:

>> Added jar event support to socket adapters.
>> 
>> Added the test jdk/jfr/event/io/TestSocketAdapterEvents.java
>
> Tim Prinzing has updated the pull request incrementally with one additional commit since the last revision:
> 
>   changes from review:
>   
>   - use loopback address
>   - fetch timeout once
>   - formatting improvements

src/java.base/share/classes/sun/nio/ch/SocketInputStream.java line 2:

> 1: /*
> 2:  * Copyright (c) 2022,2023 Oracle and/or its affiliates. All rights reserved.

I think the Oracle copyright header checker will ask you to put a space after the comma.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16251#discussion_r1372950705


More information about the nio-dev mailing list