RFR: 8335771: Improve stability of java/nio/channels/DatagramChannel tests [v4]
Alan Bateman
alanb at openjdk.org
Thu Aug 15 14:23:53 UTC 2024
On Wed, 14 Aug 2024 09:43:28 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:
>> Several `java/nio/channels/DatagramChannel` tests fail intermittently. Though it seems difficult to fix all intermittent failures due to the nature of what some of these attempt to test, the stability can still be improved.
>>
>> The most common source of intermittent failures are:
>>
>> - not receiving a datagram due to port conflict or interference of concurrent running tests
>> - failure to disconnect due to interference of concurrent running tests
>> - failure due to reception of unexpected stray datagrams
>>
>> Avoiding to bind on the wildcard address, filtering unexpected datagram, and some retrying can aleviate some of the issues and greatly reduce the frequency of intermittent failures.
>
> Daniel Fuchs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>
> - Merge branch 'master' into JDK-8335771
> - Review feedback
> - Review feedback: avoid continue
> - Review feedback
> - 8335771
I think this is okay, a bit annoying to see the workarounds for macOS issues but it should help test stability.
-------------
Marked as reviewed by alanb (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/20050#pullrequestreview-2240499705
More information about the nio-dev
mailing list