RFR: 8335771: Improve stability of java/nio/channels/DatagramChannel tests [v4]

Daniel Fuchs dfuchs at openjdk.org
Thu Aug 15 15:13:52 UTC 2024


On Thu, 15 Aug 2024 14:10:53 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Daniel Fuchs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>> 
>>  - Merge branch 'master' into JDK-8335771
>>  - Review feedback
>>  - Review feedback: avoid continue
>>  - Review feedback
>>  - 8335771
>
> test/jdk/java/nio/channels/DatagramChannel/Connect.java line 128:
> 
>> 126:                 // To avoid this, when on macOS, we preemptively bind `dc` to the
>> 127:                 // specific address instead of letting it bind to the wildcard.
>> 128:                 if (Platform.isOSX()) {
> 
> Okay, but does feel like we are working around a macOS bug.

Well - yes it kind of is. But it would be a shame to problem list the test just for this.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20050#discussion_r1718473288


More information about the nio-dev mailing list