RFR: 8324048: (fc) Make FileKey fields final [v2]

Alan Bateman alanb at openjdk.org
Thu Aug 22 06:55:07 UTC 2024


On Wed, 21 Aug 2024 19:36:03 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> Replace use of IDs to set FileKey fields from native with passing down an array, at the expense of an array allocation.
>
> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8324048: Add and reinstate IOUtil.load(); change long to jlong

Thanks for restoring the IOUtil.load, having loadLibrary be explicit in native code beyond libjava is useful to avoid surprises.

src/java.base/windows/native/libnio/ch/FileKey.c line 35:

> 33: JNIEXPORT void JNICALL
> 34: Java_sun_nio_ch_FileKey_init(JNIEnv *env, jclass clazz, jobject fdo,
> 35:     jintArray finfo)

Minor nit, no need for the line break in the function declaration.

-------------

Marked as reviewed by alanb (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20429#pullrequestreview-2253612305
PR Review Comment: https://git.openjdk.org/jdk/pull/20429#discussion_r1726429330


More information about the nio-dev mailing list