RFR: 8324048: (fc) Make FileKey fields final [v2]

Brian Burkhalter bpb at openjdk.org
Thu Aug 22 15:02:21 UTC 2024


On Thu, 22 Aug 2024 06:52:25 GMT, Alan Bateman <alanb at openjdk.org> wrote:

> Thanks for restoring the IOUtil.load, having loadLibrary be explicit in native code beyond libjava is useful to avoid surprises.

It will be removed if #20317 goes in.

> src/java.base/windows/native/libnio/ch/FileKey.c line 35:
> 
>> 33: JNIEXPORT void JNICALL
>> 34: Java_sun_nio_ch_FileKey_init(JNIEnv *env, jclass clazz, jobject fdo,
>> 35:     jintArray finfo)
> 
> Minor nit, no need for the line break in the function declaration.

Removed in [eafff23](https://github.com/openjdk/jdk/pull/20429/commits/eafff235646c70d72952c40928776b69c1bb33c9).

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20429#issuecomment-2304881620
PR Review Comment: https://git.openjdk.org/jdk/pull/20429#discussion_r1727229076


More information about the nio-dev mailing list