RFR: 8345421: (bf) Create specific test for temporary direct buffers and the buffer size limit [v2]
Alan Bateman
alanb at openjdk.org
Tue Dec 10 19:53:40 UTC 2024
On Tue, 10 Dec 2024 18:06:29 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:
>> Add a specific test for [JDK-8344882](https://bugs.openjdk.org/browse/JDK-8344882).
>
> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>
> 8345421: Add sub-test for newInputStream
test/jdk/java/nio/Buffer/UnmeteredTempBuffers.java line 55:
> 53: }
> 54: } finally {
> 55: Files.deleteIfExists(file);
I think this can be Files.delete as the file will exist.
test/jdk/java/nio/Buffer/UnmeteredTempBuffers.java line 66:
> 64: byte[] bytes = new byte[cap];
> 65: Files.write(file, bytes);
> 66: InputStream in = Files.newInputStream(file);
I assume this should use try-with-resources.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22525#discussion_r1878738434
PR Review Comment: https://git.openjdk.org/jdk/pull/22525#discussion_r1878738731
More information about the nio-dev
mailing list