RFR: 8345421: (bf) Create specific test for temporary direct buffers and the buffer size limit [v2]

Brian Burkhalter bpb at openjdk.org
Tue Dec 10 20:07:38 UTC 2024


On Tue, 10 Dec 2024 19:50:51 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8345421: Add sub-test for newInputStream
>
> test/jdk/java/nio/Buffer/UnmeteredTempBuffers.java line 55:
> 
>> 53:             }
>> 54:         }  finally {
>> 55:             Files.deleteIfExists(file);
> 
> I think this can be Files.delete as the file will exist.

As it's opened with `DELETE_ON_CLOSE` maybe the delete is not even needed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22525#discussion_r1878757036


More information about the nio-dev mailing list