RFR: 8345421: (bf) Create specific test for temporary direct buffers and the buffer size limit [v2]

Alan Bateman alanb at openjdk.org
Wed Dec 11 06:59:39 UTC 2024


On Tue, 10 Dec 2024 20:05:21 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> test/jdk/java/nio/Buffer/UnmeteredTempBuffers.java line 55:
>> 
>>> 53:             }
>>> 54:         }  finally {
>>> 55:             Files.deleteIfExists(file);
>> 
>> I think this can be Files.delete as the file will exist.
>
> As it's opened with `DELETE_ON_CLOSE` maybe the delete is not even needed.

Just a bit surprising to see it in this test, but okay.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22525#discussion_r1879445767


More information about the nio-dev mailing list