RFR: 8325028: (ch) Pipe channels should lazily set socket to non-blocking mode on first use by virtual thread

Jaikiran Pai jpai at openjdk.org
Thu Feb 8 07:43:55 UTC 2024


On Wed, 31 Jan 2024 09:03:14 GMT, Alan Bateman <alanb at openjdk.org> wrote:

> The Unix implementation of the Pipe source/sink channels eagerly configures the underlying socket to be non-blocking in case the pipe is used by a virtual thread. It can be done lazily, as done with the network channels. No changes to the semantics of the APIs, and well tested by the existing tests.

Hello Alan, is the use of the word "socket" in the comments and the method names (and the PR title) intentional? As far as I can see the sink/source channels' underlying resources are file descriptors created out of a `pipe()` call. Do we use the term "socket" for such cases too?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17648#issuecomment-1933515467


More information about the nio-dev mailing list