RFR: 8325028: (ch) Pipe channels should lazily set socket to non-blocking mode on first use by virtual thread

Alan Bateman alanb at openjdk.org
Thu Feb 8 08:02:58 UTC 2024


On Thu, 8 Feb 2024 07:41:44 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Hello Alan, is the use of the word "socket" in the comments and the method names (and the PR title) intentional? 

These channels can work with pipes or an unnamed pair of connected sockets. In the Windows implementation they use a Unix domain socket or a TCP socket, depending not on which Windows release. So I kept the comment using "socket" but you are right that it might be a bit clearer to say pipe in the Unix implementation. We can adjust this comment when next touching this area (as the changes here are already integrated).

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17648#issuecomment-1933539273


More information about the nio-dev mailing list