RFR: 8334297: (so) java/nio/channels/SocketChannel/OpenLeak.java should not depend on SecurityManager [v3]

Vyom Tewari vtewari at openjdk.org
Fri Jun 14 17:33:12 UTC 2024


On Fri, 14 Jun 2024 15:57:29 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> The test java/nio/channels/SocketChannel/OpenLeak.java depends on the SecurityManager to trigger an exception in SocketChannel::connect.
>> 
>> This change rewrites it to connect to a TCP reserved port instead, such as port 47, 51, or 61, in order to trigger a `ConnectException` instead of a `SecurityException`.
>> 
>> The original issue that this test tried to check for was:
>> https://bugs.openjdk.org/browse/JDK-6548464
>
> Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Minor cleanup

test/jdk/java/nio/channels/SocketChannel/OpenLeak.java line 44:

> 42: public class OpenLeak {
> 43: 
> 44:     private static final int MAX_LOOP = 250000;

Overall changes looks good to me but do you need to loop  25000 times ?.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19723#discussion_r1640149631


More information about the nio-dev mailing list