RFR: 8334297: (so) java/nio/channels/SocketChannel/OpenLeak.java should not depend on SecurityManager [v3]
Daniel Fuchs
dfuchs at openjdk.org
Fri Jun 14 17:42:17 UTC 2024
On Fri, 14 Jun 2024 17:30:58 GMT, Vyom Tewari <vtewari at openjdk.org> wrote:
>> Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Minor cleanup
>
> test/jdk/java/nio/channels/SocketChannel/OpenLeak.java line 44:
>
>> 42: public class OpenLeak {
>> 43:
>> 44: private static final int MAX_LOOP = 250000;
>
> Overall changes looks good to me but do you need to loop 25000 times ?.
Actually 250000 times ;-)
Yes - without the close() the test starts failling for me on my machine at around 247500 iterations. So if we really want to test that the issue the original test was trying to verify is fixed we need that, I believe.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19723#discussion_r1640157053
More information about the nio-dev
mailing list