RFR: 8327370: (ch) sun.nio.ch.Poller.register throws AssertionError [v2]
Jaikiran Pai
jpai at openjdk.org
Thu Jun 20 14:23:10 UTC 2024
On Thu, 20 Jun 2024 11:10:24 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:
>> Please find here an almost trivial change that fixes an intermittent AssertionError observed in `sun.nio.ch.Poller`.
>>
>> This change (in the mist of a bigger fix) was contributed by @AlanBateman to the loom repo two weeks ago.
>
> Daniel Fuchs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>
> - Merge branch 'master' into JDK-8327370
> - Fix mistake - catch Throwable to cover more cases
> - 8327370
The change looks reasonable to me and looking at the code that's the only place where an entry would be inserted into the map, so this change isn't needed in any other call sites.
-------------
Marked as reviewed by jpai (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/19792#pullrequestreview-2130591414
More information about the nio-dev
mailing list