RFR: 8327370: (ch) sun.nio.ch.Poller.register throws AssertionError [v2]

Daniel Fuchs dfuchs at openjdk.org
Thu Jun 20 14:52:11 UTC 2024


On Thu, 20 Jun 2024 14:20:59 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Daniel Fuchs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Merge branch 'master' into JDK-8327370
>>  - Fix mistake - catch Throwable to cover more cases
>>  - 8327370
>
> The change looks reasonable to me and looking at the code that's the only place where an entry would be inserted into the map, so this change isn't needed in any other call sites.

Thanks @jaikiran

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19792#issuecomment-2180901350


More information about the nio-dev mailing list