RFR: 8334339: Test java/nio/file/attribute/BasicFileAttributeView/CreationTime.java fails on alinux3 [v3]

[SendaoYan]

On Fri, 21 Jun 2024 16:09:06 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> SendaoYan has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - delete unneeded import
>>  - If the file system doesn't support birth time, then skip this test
>
> test/jdk/java/nio/file/attribute/BasicFileAttributeView/CreationTime.java line 34:
> 
>> 32: 
>> 33: /* @test id=cwd
>> 34:  * @bug 8011536 8151430 8316304 8334339
> 
> You can drop the list of bugs in the second test description, it only need to be in the first one.

Thanks for the review, the code has been changed.

> test/jdk/java/nio/file/attribute/BasicFileAttributeView/CreationTime.java line 148:
> 
>> 146:         // create temporary directory to run tests
>> 147:         Path dir;
>> 148:         if(0 == args.length) {
> 
> Can you change this to `if (args.length == 0)`  ?

Thanks for the review, the code has been changed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19737#discussion_r1649169782
PR Review Comment: https://git.openjdk.org/jdk/pull/19737#discussion_r1649169657