RFR: 8334339: Test java/nio/file/attribute/BasicFileAttributeView/CreationTime.java fails on alinux3 [v3]

SendaoYan syan at openjdk.org
Fri Jun 21 16:24:23 UTC 2024


On Fri, 21 Jun 2024 16:09:06 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> SendaoYan has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - delete unneeded import
>>  - If the file system doesn't support birth time, then skip this test
>
> test/jdk/java/nio/file/attribute/BasicFileAttributeView/CreationTime.java line 34:
> 
>> 32: 
>> 33: /* @test id=cwd
>> 34:  * @bug 8011536 8151430 8316304 8334339
> 
> You can drop the list of bugs in the second test description, it only need to be in the first one.

Okey, the list of bugs in the second test description has been deleted.

> test/jdk/java/nio/file/attribute/BasicFileAttributeView/CreationTime.java line 37:
> 
>> 35:  * @summary Basic test for creationTime attribute on platforms/file systems
>> 36:  *     that support it, test directory is JTwork/scratch. The JTwork/scratch
>> 37:  *     directory maybe at diff disk partition to /tmp on linux
> 
> I think you should want to say that it tests using the test scratch directory.

The @summary description has been updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19737#discussion_r1649177610
PR Review Comment: https://git.openjdk.org/jdk/pull/19737#discussion_r1649173952


More information about the nio-dev mailing list