RFR: 8327096: (fc) java/nio/channels/FileChannel/Size.java fails on partition incapable of creating large files
Brian Burkhalter
bpb at openjdk.org
Mon Mar 11 17:58:53 UTC 2024
On Mon, 11 Mar 2024 09:51:01 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:
>> If an `IOException` with message "File too large" is thrown while testing with a large file, then ignore the exception if the type of the `FileStore` where the file would be located is "msdos".
>
> test/jdk/java/nio/channels/FileChannel/Size.java line 87:
>
>> 85: FileStore store = p.getFileSystem().provider().getFileStore(p);
>> 86: if ("msdos".equals(store.type())) // FAT32
>> 87: return; // ignore IOE: file too big for 32 bits
>
> Throwing a SkippedException might be more appropriate here
`SkippedException` is EE, no?
I think the main question is whether to ignore or throw.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18073#discussion_r1520187108
More information about the nio-dev
mailing list