RFR: 8327096: (fc) java/nio/channels/FileChannel/Size.java fails on partition incapable of creating large files

[Daniel Jeliński]

On Mon, 11 Mar 2024 17:56:24 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> test/jdk/java/nio/channels/FileChannel/Size.java line 87:
>> 
>>> 85:                 FileStore store = p.getFileSystem().provider().getFileStore(p);
>>> 86:                 if ("msdos".equals(store.type())) // FAT32
>>> 87:                     return; // ignore IOE: file too big for 32 bits
>> 
>> Throwing a SkippedException might be more appropriate here
>
> `SkippedException` is EE, no?
> 
> I think the main question is whether to ignore or throw.

I was referring to `jtreg.SkippedException`. See: https://openjdk.org/jtreg/faq.html#what-if-a-test-does-not-apply-in-a-given-situation
If you throw that, the test will still pass.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18073#discussion_r1520284094