RFR: 8327095: (ch) java/nio/channels/AsyncCloseAndInterrupt.java: improve error message when mkfifo fails

Daniel Jeliński djelinski at openjdk.org
Mon Mar 11 19:20:16 UTC 2024


On Thu, 29 Feb 2024 23:48:12 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

> Add to the error message of the `IOException` thrown when the `mkfifo` command fails:
> 
> 1. the absolute path of the FIFO which was to have been created;
> 2. the text read from the standard error stream of the process in which `mkfifo` was executed.

test/jdk/java/nio/channels/AsyncCloseAndInterrupt.java line 137:

> 135:         }
> 136:         Process p = Runtime.getRuntime().exec("mkfifo " + fifoFile);
> 137:         if (p.waitFor() != 0) {

use ProcessTools.executeProcess for this; it has facilities to check the exit code and dump process output on failure.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18072#discussion_r1520303030


More information about the nio-dev mailing list