RFR: 8327095: (ch) java/nio/channels/AsyncCloseAndInterrupt.java: improve error message when mkfifo fails [v3]

Brian Burkhalter bpb at openjdk.org
Mon Mar 11 22:44:25 UTC 2024


On Mon, 11 Mar 2024 19:17:08 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

>> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8327095: Improve ProcessTools use
>
> test/jdk/java/nio/channels/AsyncCloseAndInterrupt.java line 137:
> 
>> 135:         }
>> 136:         Process p = Runtime.getRuntime().exec("mkfifo " + fifoFile);
>> 137:         if (p.waitFor() != 0) {
> 
> use ProcessTools.executeProcess for this; it has facilities to check the exit code and dump process output on failure.

See version as of commit 79b3c50e7a32472bcfc5cd8026254257a0d210b0.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18072#discussion_r1520508468


More information about the nio-dev mailing list