RFR: 8327095: (ch) java/nio/channels/AsyncCloseAndInterrupt.java: improve error message when mkfifo fails [v5]

Alan Bateman alanb at openjdk.org
Wed Mar 13 07:24:15 UTC 2024


On Tue, 12 Mar 2024 22:09:27 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> Add to the error message of the `IOException` thrown when the `mkfifo` command fails:
>> 
>> 1. the absolute path of the FIFO which was to have been created;
>> 2. the text read from the standard error stream of the process in which `mkfifo` was executed.
>
> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8327095: If mkfifo fails with "Operation not supported", continue with a warning instead of failing

test/jdk/java/nio/channels/AsyncCloseAndInterrupt.java line 157:

> 155:             }
> 156:         }
> 157:         new RandomAccessFile(fifoFile, "rw").close();

Having you looked at using FFM to call mkinfo(2) rather launching a process to run the mkfifo tool? It's very brittle to depend on output like "Operation not supported".

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18072#discussion_r1522655093


More information about the nio-dev mailing list