RFR: 8327095: (ch) java/nio/channels/AsyncCloseAndInterrupt.java: improve error message when mkfifo fails [v5]

Brian Burkhalter bpb at openjdk.org
Wed Mar 13 15:43:13 UTC 2024


On Wed, 13 Mar 2024 07:21:35 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8327095: If mkfifo fails with "Operation not supported", continue with a warning instead of failing
>
> test/jdk/java/nio/channels/AsyncCloseAndInterrupt.java line 157:
> 
>> 155:             }
>> 156:         }
>> 157:         new RandomAccessFile(fifoFile, "rw").close();
> 
> Having you looked at using FFM to call mkinfo(2) rather launching a process to run the mkfifo tool? It's very brittle to depend on output like "Operation not supported".

No, not yet. The test was already launching a process. I would prefer to pursue trying FFM, however, as part of a subsequent, follow-on request rather than in this one.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18072#discussion_r1523504502


More information about the nio-dev mailing list