RFR: 8313674: java/nio/channels/FileChannel/BlockDeviceSize.java should test for more block devices [v2]

[Inigo Mediavilla Saiz]

On Wed, 1 May 2024 06:57:00 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Inigo Mediavilla Saiz has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Replace getBlkPath method by Paths.get
>
> test/jdk/java/nio/channels/FileChannel/BlockDeviceSize.java line 57:
> 
>> 55:                 long size1 = ch.size();
>> 56:                 long size2 = file.length();
>> 57:                 if (size1 != size2) {
> 
> A passing comment on this test is that it just checks that FC::size and RAF::size return the same size. We are sitting on prototype changes that reimplement RAF on FC so it won't be comparing two different implementations if that goes ahead. It will at least test that the size method doesn't throw.

Ok, so if I'm understanding well your comment, it will still make sense to keep this test even if it's only as a validation that the `.size` call won't fail, while the `size1 != size2` will become irrelevant when the changes that you're mentioning get merged.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19021#discussion_r1587178354