RFR: 8313674: java/nio/channels/FileChannel/BlockDeviceSize.java should test for more block devices [v2]

Inigo Mediavilla Saiz duke at openjdk.org
Wed May 1 19:50:04 UTC 2024


On Wed, 1 May 2024 06:54:33 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Inigo Mediavilla Saiz has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Replace getBlkPath method by Paths.get
>
> test/jdk/java/nio/channels/FileChannel/BlockDeviceSize.java line 51:
> 
>> 49:     public static void main(String[] args) throws Throwable {
>> 50:         for (String blkFname: BLK_FNAMES) {
>> 51:             Path blkPath = getBlkPath(blkFname);
> 
> You can replace this with Path.of(blkFname), no need for the getBlkPath method.

Indeed, it seems unnecessary to create a method only for that. I've included your suggestion with 08744f4262c7b63b25c7c4e65c430948447f711f.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19021#discussion_r1586745741


More information about the nio-dev mailing list