RFR: 8313674: java/nio/channels/FileChannel/BlockDeviceSize.java should test for more block devices [v2]
Inigo Mediavilla Saiz
duke at openjdk.org
Thu May 2 13:00:56 UTC 2024
On Thu, 2 May 2024 07:50:25 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> Ok, so if I'm understanding well your comment, it will still make sense to keep this test even if it's only as a validation that the `.size` call won't fail, while the `size1 != size2` will become irrelevant when the changes that you're mentioning get merged.
>
> That's right, the best we can do then is to check that size is >= 0.
Perfect, I'll leave the check there, and we can change it to `size() >= 0` when the reimplementation of RAF on FC is done.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19021#discussion_r1587594742
More information about the nio-dev
mailing list