RFR: 8313674: java/nio/channels/FileChannel/BlockDeviceSize.java should test for more block devices [v2]

Alan Bateman alanb at openjdk.org
Sun May 5 05:36:51 UTC 2024


On Thu, 2 May 2024 12:57:50 GMT, Inigo Mediavilla Saiz <duke at openjdk.org> wrote:

>> That's right, the best we can do then is to check that size is >= 0.
>
> Perfect, I'll leave the check there, and we can change it to `size() >= 0` when the reimplementation of RAF on FC is done.

The summary in the test description is "Block devices should not report size=0 on Linux". This test will actually pass if the block device size is reported as 0. So I think the test summary needs to change or the test checks that the size is > 0.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19021#discussion_r1590213137


More information about the nio-dev mailing list