RFR: 8313674: java/nio/channels/FileChannel/BlockDeviceSize.java should test for more block devices [v3]
Inigo Mediavilla Saiz
duke at openjdk.org
Mon May 6 07:50:52 UTC 2024
On Wed, 1 May 2024 22:53:58 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:
>> The devices included are only the two most popular block devices in Linux. I'd tend to say that having those two should provide enough coverage, but I'm open to including others.
>>
>> For reference, this [link](https://github.com/brianmcgillion/udev/blob/master/rules/rules.d/60-persistent-storage.rules) gives an idea of the rules that udev uses to name devices. An example that I didn't consider and that appears in the udev rules is `/dev/mmcblk0`, a device that must be very popular in the raspberry pi community.
>
> I'm not familiar enough with which devices need to be covered. If there are more devices of non-negligible interest, however, and adding them would neither destabilize the test nor substantially increase the test's running time, then I would not hesitate to add a few. On the other if you think this is enough, I cannot disagree.
I've thought about it and in the end I've also added `/dev/xvda1`. That should allow running the test in virtualized environments, what should increase significantly the coverage. I believe those three devices should be a very representative set of the environments where this test will be run.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19021#discussion_r1590655620
More information about the nio-dev
mailing list