RFR: 8313674: java/nio/channels/FileChannel/BlockDeviceSize.java should test for more block devices [v4]

Inigo Mediavilla Saiz duke at openjdk.org
Tue May 7 12:23:19 UTC 2024


On Sun, 5 May 2024 05:34:30 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Perfect, I'll leave the check there, and we can change it to `size() >= 0` when the reimplementation of RAF on FC is done.
>
> The summary in the test description is "Block devices should not report size=0 on Linux". This test will actually pass if the block device size is reported as 0. So I think the test summary needs to change or the test checks that the size is > 0.

You're correct. I believe that until the prototype changes are merged we can keep the equality tests and add a `!= 0` test.

See: https://github.com/openjdk/jdk/pull/19021/commits/e7fd93af9815d1643122d99135df3ac75e6a939c

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19021#discussion_r1592389083


More information about the nio-dev mailing list