RFR: 8313674: java/nio/channels/FileChannel/BlockDeviceSize.java should test for more block devices [v5]

Alan Bateman alanb at openjdk.org
Mon May 13 08:36:40 UTC 2024


On Mon, 13 May 2024 07:51:21 GMT, Inigo Mediavilla Saiz <duke at openjdk.org> wrote:

>> 8313674: java/nio/channels/FileChannel/BlockDeviceSize.java should test for more block devices
>
> Inigo Mediavilla Saiz has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use Path.of instead of Paths.get

The update to the test looks okay to me, and I think useful to have the test changed to check > 0 is good. It might be clearer to have it fail if <= 0 of course.

I assume you'll bump the end date in the copyright header.

-------------

Marked as reviewed by alanb (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19021#pullrequestreview-2052027102


More information about the nio-dev mailing list