RFR: 8313674: java/nio/channels/FileChannel/BlockDeviceSize.java should test for more block devices [v5]
Inigo Mediavilla Saiz
duke at openjdk.org
Mon May 13 08:36:41 UTC 2024
On Mon, 13 May 2024 08:27:01 GMT, Alan Bateman <alanb at openjdk.org> wrote:
> The update to the test looks okay to me, and I think useful to have the test changed to check > 0 is good. It might be clearer to have it fail if <= 0 of course.
>
> I assume you'll bump the end date in the copyright header.
>
Thanks @AlanBateman !
I've updated the copyright in: https://github.com/openjdk/jdk/pull/19021/commits/78af373b3df429ea2683293517f2c75b0c12b00e
And updated the failure condition to `<=` in: https://github.com/openjdk/jdk/pull/19021/commits/868a40fddb6d6167e00cc0dbfc39470c9cbf4985
-------------
PR Comment: https://git.openjdk.org/jdk/pull/19021#issuecomment-2106968490
More information about the nio-dev
mailing list