RFR: 8327650: Test java/nio/channels/DatagramChannel/StressNativeSignal.java timed out

[Mark Sheppard]

On Tue, 21 May 2024 19:41:27 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> I can do that, but the change is just maintaining the existing call flow, which would have any exception caught and continues with a stack trace dump. In this case we continue countdown the latch, an NPE is thrown, caught with stack trace and finish.
>> But we'll move to a Constructor as suggested.
>
> The catching of Exception looks like it's new code in this PR, did I mis-read it? In any case, I think it will be much better to do this in the constructor. Same thing in UDPThread where the code in the run method to catch IOException + continue is very surprising.

yes, your point is well made , changes have been made as suggested ... I was just trying to say that I was following the idioms in the existing code ... the existing test code appears to be ambivalent to any exceptions, its sole purpose is to try to elicit a 316 error on macOS

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19312#discussion_r1608924232