RFR: 8327650: Test java/nio/channels/DatagramChannel/StressNativeSignal.java timed out [v4]
Mark Sheppard
msheppar at openjdk.org
Tue May 28 13:25:10 UTC 2024
On Tue, 21 May 2024 20:37:43 GMT, Mark Sheppard <msheppar at openjdk.org> wrote:
>> The catching of Exception looks like it's new code in this PR, did I mis-read it? In any case, I think it will be much better to do this in the constructor. Same thing in UDPThread where the code in the run method to catch IOException + continue is very surprising.
>
> yes, your point is well made , changes have been made as suggested ... I was just trying to say that I was following the idioms in the existing code ... the existing test code appears to be ambivalent to any exceptions, its sole purpose is to try to elicit a 316 error on macOS
done
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19312#discussion_r1617239809
More information about the nio-dev
mailing list