RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v3]
Alexey Ivanov
aivanov at openjdk.org
Thu Oct 24 20:30:39 UTC 2024
On Thu, 24 Oct 2024 18:09:04 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:
>> src/java.desktop/share/classes/java/awt/Desktop.java line 713:
>>
>>> 711: * {@code Info.plist}.
>>> 712: *
>>> 713: * @param printFileHandler handler
>>
>> Suggestion:
>>
>> * @param printFileHandler handler
>> *
>>
>> ~~Can we add a blank line here? It's present in the methods above.~~
>>
>> Although there are other places below where it's missing; _so not worth worrying_.
>
> @seanjmullan Can you please advice on some of the following src file javadoc related review comments. Do they need to be handled in this PR? Some of them seem out-of-scope for jep486 PR.
@honkar-jdk I'm inclined to leave it as because it's not the only method which doesn't have a blank line between `@param` and `@throw` in this file.
If it's worth taking care of, we may submit another bug to address it later.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21498#discussion_r1815657461
More information about the nio-dev
mailing list