RFR: 8338884: java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3 [v10]

SendaoYan syan at openjdk.org
Sat Sep 7 02:34:45 UTC 2024


On Fri, 6 Sep 2024 08:56:00 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix typo support to supported
>
> test/jdk/java/nio/file/attribute/BasicFileAttributeView/CreationTimeHelper.java line 51:
> 
>> 49:             return (boolean)methodHandle.invokeExact(s);
>> 50:         }
>> 51:     }
> 
> We should only do the downcall if we know `statx` is available. I.e. return `false` early when `!abi.defaultLookup().find("statx").isPresent()`

Okey, code `return false early if statx syscall is not available` has been added.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20687#discussion_r1747872673


More information about the nio-dev mailing list