RFR: 8338884: java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3 [v10]
SendaoYan
syan at openjdk.org
Sat Sep 7 02:53:50 UTC 2024
On Fri, 6 Sep 2024 09:07:10 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:
>> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
>>
>> fix typo support to supported
>
> test/jdk/java/nio/file/attribute/BasicFileAttributeView/libCreationTimeHelper.c line 121:
>
>> 119: return false;
>> 120: }
>> 121: if (stx.stx_mask & STATX_BTIME)
>
> `if (stx.stx_mask & STAX_BTIME) != 0)` please. Also, please add a comment mentioning that "on some systems where `statx` is available birth time might still not be supported as it's file system specific. The only reliable way to check for support is looking at the filled in STATX_BTIME bit in the returned statx buffer mask."
Thanks for your patient code review.
`STATX_BTIME` return statx buffer mask convert to boolean explicitly, and add comment to explain why get `STATX_BTIME` bit.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20687#discussion_r1747877454
More information about the nio-dev
mailing list