RFR: 8338884: java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3 [v10]

SendaoYan syan at openjdk.org
Mon Sep 9 02:30:09 UTC 2024


On Sat, 7 Sep 2024 03:04:46 GMT, SendaoYan <syan at openjdk.org> wrote:

>> test/jdk/java/nio/file/attribute/BasicFileAttributeView/libCreationTimeHelper.c line 30:
>> 
>>> 28:   #define true 1
>>> 29:   #define false 0
>>> 30: #endif
>> 
>> Do we really need this? Since https://openjdk.org/jeps/347 test libraries should be compiled with `--std=c11`.
>
> I think I need some time to study that.

I found other tests such as `test/jdk/java/foreign/libIntrinsics.c` only `#include <stdbool.h>` to use bool type. So I think these codes can change to only `#include <stdbool.h>`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20687#discussion_r1749476268


More information about the nio-dev mailing list