RFR: 8338884: java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3 [v10]

[SendaoYan]

On Fri, 6 Sep 2024 09:19:25 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix typo support to supported
>
> test/jdk/java/nio/file/attribute/BasicFileAttributeView/CreationTime.java line 83:
> 
>> 81:             System.out.println("creationTime.toMillis() == " + creationTime.toMillis());
>> 82:             // If the file system doesn't support birth time, then skip this test
>> 83:             if (creationTime.toMillis() == 0) {
> 
> Is this still useful? After https://bugs.openjdk.org/browse/JDK-8338696 we'd never get the epoch (`0`). If birth time is not supported, the last modified time is being returned. I think this can go and the `SkippedException` branch removed as well.

Thanks for your correction, the `SkippedException` for epoch (0) has been deleted.

> test/jdk/java/nio/file/attribute/BasicFileAttributeView/libCreationTimeHelper.c line 30:
> 
>> 28:   #define true 1
>> 29:   #define false 0
>> 30: #endif
> 
> Do we really need this? Since https://openjdk.org/jeps/347 test libraries should be compiled with `--std=c11`.

I think I need some time to study that.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20687#discussion_r1747880627
PR Review Comment: https://git.openjdk.org/jdk/pull/20687#discussion_r1747881022