RFR: 8338884: java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3 [v15]
SendaoYan
syan at openjdk.org
Mon Sep 9 12:02:26 UTC 2024
On Mon, 9 Sep 2024 08:13:41 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:
>> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
>>
>> After JEP 347, we can use bool type only "#include <stdbool.h>"
>
> test/jdk/java/nio/file/attribute/BasicFileAttributeView/CreationTimeHelper.java line 48:
>
>> 46: static boolean linuxIsCreationTimeSupported(String file) throws Throwable {
>> 47: if (!abi.defaultLookup().find("statx").isPresent())
>> 48: return false;
>
> I personally prefer using `if (...) { /* do something */ }` (add curly brackets).
Thanks for your patient code review again.
1. curly brackets in function linuxIsCreationTimeSupported has been added; 2. comment for function linuxIsCreationTimeSupported has been complemented.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20687#discussion_r1750127468
More information about the nio-dev
mailing list