RFR: 8338884: java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3 [v15]
SendaoYan
syan at openjdk.org
Mon Sep 9 12:42:24 UTC 2024
On Mon, 9 Sep 2024 08:30:28 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:
>> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
>>
>> After JEP 347, we can use bool type only "#include <stdbool.h>"
>
> test/jdk/java/nio/file/attribute/BasicFileAttributeView/libCreationTimeHelper.c line 91:
>
>> 89: struct my_statx stx;
>> 90: int ret, atflag = AT_SYMLINK_NOFOLLOW;
>> 91: memset(&stx, 0xbf, sizeof(stx));
>
> Why `0xbf`?
>
> How about `struct my_statx stx = {0}`?
I implement this code imitate from [test-statx.c](https://github.com/torvalds/linux/blob/master/samples/vfs/test-statx.c#L251), and I'm not quite sure why the testcase initial struct var stx to `0xbf`. I think initial to zero will be Okey also.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20687#discussion_r1750177644
More information about the nio-dev
mailing list