RFR: 8340404: Clarify CharsetProvider deployment on application module path

[Alan Bateman]

On Thu, 19 Sep 2024 00:07:30 GMT, Justin Lu <jlu at openjdk.org> wrote:

> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8340412) which clarifies that a CharsetProvider SPI can be provided via the application module path.
> 
> This came as a result from a comment on the PR of JDK-8339735. 
> 
> I included some minor wording on deploying as a module, with a link to `Service Loader's` _Developing Service Providers section_ to handle the heavy lifting. However, I am happy to adjust as needed, if it is felt that more info should be laid out directly on `CharsetProvider's` class description itself.
> 
> An associated test is provided to confirm that a `CharsetProvider` _can_ be deployed as a module.

test/jdk/java/nio/charset/spi/CharsetProviderAsModuleTest.java line 28:

> 26:  * @bug 8340404
> 27:  * @summary Check that a CharsetProvider SPI can be deployed as a module
> 28:  * @modules provider

The `@modules` tag is used for test selection, I don't know what L28 does.

test/jdk/java/nio/charset/spi/CharsetProviderAsModuleTest.java line 29:

> 27:  * @summary Check that a CharsetProvider SPI can be deployed as a module
> 28:  * @modules provider
> 29:  * @build provider/module-info provider/spi.BazProvider

You can use `@build provider/*` here and jtreg will do the right thing.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21076#discussion_r1766196688
PR Review Comment: https://git.openjdk.org/jdk/pull/21076#discussion_r1766195932