RFR: 8340404: Clarify CharsetProvider deployment on application module path [v2]
Justin Lu
jlu at openjdk.org
Thu Sep 19 16:55:49 UTC 2024
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8340412) which clarifies that a CharsetProvider SPI can be provided via the application module path.
>
> This came as a result from a comment on the PR of JDK-8339735.
>
> I included some minor wording on deploying as a module, with a link to `Service Loader's` _Developing Service Providers section_ to handle the heavy lifting. However, I am happy to adjust as needed, if it is felt that more info should be laid out directly on `CharsetProvider's` class description itself.
>
> An associated test is provided to confirm that a `CharsetProvider` _can_ be deployed as a module.
Justin Lu has updated the pull request incrementally with two additional commits since the last revision:
- merge master, resolve conflicts
- reflect review comments
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/21076/files
- new: https://git.openjdk.org/jdk/pull/21076/files/a9cb9db1..6aff4f3f
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=21076&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=21076&range=00-01
Stats: 1651 lines in 75 files changed: 1360 ins; 36 del; 255 mod
Patch: https://git.openjdk.org/jdk/pull/21076.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/21076/head:pull/21076
PR: https://git.openjdk.org/jdk/pull/21076
More information about the nio-dev
mailing list