RFR: 8340404: Clarify CharsetProvider deployment on application module path [v4]

[Alan Bateman]

On Thu, 19 Sep 2024 17:05:49 GMT, Justin Lu <jlu at openjdk.org> wrote:

>> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8340412) which clarifies that a CharsetProvider SPI can be provided via the application module path.
>> 
>> This came as a result from a comment on the PR of JDK-8339735. 
>> 
>> I included some minor wording on deploying as a module, with a link to `Service Loader's` _Developing Service Providers section_ to handle the heavy lifting. However, I am happy to adjust as needed, if it is felt that more info should be laid out directly on `CharsetProvider's` class description itself.
>> 
>> An associated test is provided to confirm that a `CharsetProvider` _can_ be deployed as a module.
>
> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   drop obsolete 'extensions' sentence

src/java.base/share/classes/java/nio/charset/spi/CharsetProvider.java line 43:

> 41:  * loader}. See {@link java.util.ServiceLoader##developing-service-providers
> 42:  * Deploying Service Providers} for further detail on deploying a charset
> 43:  * provider as a module or on the class path.

I think it would better to say "deployed" rather than "available" here, that will align with the later text.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21076#discussion_r1768587575