RFR: 8340404: Clarify CharsetProvider deployment on application module path [v4]

Justin Lu jlu at openjdk.org
Fri Sep 20 23:41:11 UTC 2024


On Fri, 20 Sep 2024 13:07:05 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   drop obsolete 'extensions' sentence
>
> src/java.base/share/classes/java/nio/charset/spi/CharsetProvider.java line 43:
> 
>> 41:  * loader}. See {@link java.util.ServiceLoader##developing-service-providers
>> 42:  * Deploying Service Providers} for further detail on deploying a charset
>> 43:  * provider as a module or on the class path.
> 
> I think it would better to say "deployed" rather than "available" here, that will align with the later text.

I presume you meant the "available" on line 37 should be "deployed" and changed as such.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21076#discussion_r1769354962


More information about the nio-dev mailing list