RFR: 8351851: Update PmemTest to run on AMD64
Andrew Dinn
adinn at openjdk.org
Wed Apr 16 10:35:43 UTC 2025
On Tue, 15 Apr 2025 16:22:11 GMT, Mark Sheppard <msheppar at openjdk.org> wrote:
> It would be preferable if we retained the current test structure and swap
the x86_64 with amd64, as amd64 is the os.arch on which the test will be run
When I wrote my previous comment I was under the impression that `@requires(os.arch == "x86_64")` selects Intel x86 64-bit only while `@requires(os.arch == "amd64")` selects either Intel x86 64-bit or AMD x86 64-bit. However, having looked through the code in files:
test/jdk/jdk/internal/util/ArchTest.java
src/java.base/share/classes/jdk/internal/util/Architecture.java
src/java.base/share/classes/jdk/internal/util/PlatformProps.java
/make/modules/java.base/gensrc/GensrcMisc.gmk
it appears to me that these two `@requires` clauses select the same thing i.e. either Intel x86 64-bit or AMD x86 64-bit. In which case the current config should mean that this test will run on AMD CPUs. Is that not the case?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/24416#issuecomment-2809158221
More information about the nio-dev
mailing list