RFR: 8351851: Update PmemTest to run on AMD64
Mark Sheppard
msheppar at openjdk.org
Tue Apr 15 16:24:43 UTC 2025
On Thu, 3 Apr 2025 14:48:41 GMT, Ivan Šipka <isipka at openjdk.org> wrote:
> Remove default OS platform linux x86_64, remove @ignores allowing amd64 as a viable OS platform selection
I would prefer if we retained the current test structure and swap
the x86_64 with amd64, as amd64 is the os.arch on which the test will be run
Change
80 /* @test
81 * @summary Testing NVRAM mapped byte buffer support
82 * @run main/manual PmemTest
83 * @requires (os.family == "linux")
84 * @requires (os.arch == "x86_64")
85 */
86
87 /* @test
88 * @summary Testing NVRAM mapped byte buffer support
89 * @run main/manual PmemTest
90 * @requires (os.family == "linux")
91 * @requires ((os.arch == "amd64")|(os.arch == "aarch64")|(os.arch == "ppc64le"))
92 * @ignore The test described here is currently disabled on systems that are not
93 * x64-based and lack an external NVRAM memory device. In order to re-enable the
94 * test, you will need to mount the NVRAM device, which will typically appear as
95 * /dev/pmem0, to the directory /mnt/pmem. Once that is done, you can follow the
96 * instructions above to create a test directory and remove the ignore tag.
97 */
To the preferred change i.e. to swap the x86_64 and amd64 and to use
80 /* @test
81 * @summary Testing NVRAM mapped byte buffer support
82 * @run main/manual PmemTest
83 * @requires (os.family == "linux")
84 * @requires (os.arch == “amd64”)
85 */
91 * @requires ((os.arch == “x86_64”)|(os.arch == "aarch64")|(os.arch == "ppc64le"))
92 * @ignore The test described here is currently disabled on systems that are not
-------------
PR Comment: https://git.openjdk.org/jdk/pull/24416#issuecomment-2806732665
More information about the nio-dev
mailing list