RFR: 8351851: Update PmemTest to run on AMD64

Mark Sheppard msheppar at openjdk.org
Wed Apr 16 10:38:41 UTC 2025


On Tue, 15 Apr 2025 13:09:50 GMT, Andrew Dinn <adinn at openjdk.org> wrote:

> I'm not sure if this change is correct. The original directive was ignored and replaced with an x86_64-only directive because of automated testing concerns documented in [PR 12352](https://github.com/openjdk/jdk/pull/12352). If this change is happening because those automated test restrictions no longer apply for all three of amd64 (by which I mean not intel x86_64) aarch64 and ppc then reverting to the ignored directive would be fine. If the only change is that automated testing on amd64 now works as well as x86_64 then I would recommend modifying the first directive and keeping the ignored directive as the latter helps to clarify to general users how non-automated testing can be performed on aarch64 and ppc.

just to clarify that both instances  of @test  are **manual** and that current test environments are os.arch == "amd64", which based on the default  os.arch == "x86_64" meant the test was not run. As such, the purpose of the ticket is to make the default case "amd64"

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24416#issuecomment-2809164778


More information about the nio-dev mailing list