RFR: 8351851: Update PmemTest to run on AMD64 [v2]
Mark Sheppard
msheppar at openjdk.org
Thu Apr 17 14:57:43 UTC 2025
On Thu, 17 Apr 2025 14:40:56 GMT, Ivan Šipka <isipka at openjdk.org> wrote:
>> Remove default OS platform linux x86_64, remove @ignores allowing amd64 as a viable OS platform selection
>
> Ivan Šipka has updated the pull request incrementally with two additional commits since the last revision:
>
> - removing accidentally added files, reverting to two test cases bu removing @ignores directive and adding test ids
> - copyright update
test/jdk/java/nio/MappedByteBuffer/PmemTest.java line 87:
> 85: */
> 86:
> 87: /* @test id=other_architectures_test_case
we should to leave the @ignores for the 2nd test case
the test will be run on amd64 environmenst , as such the addition of | (os.arch == "amd64") to the first test case is fine
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24416#discussion_r2049132553
More information about the nio-dev
mailing list