RFR: 8351851: Update PmemTest to run on AMD64 [v2]

Ivan Šipka isipka at openjdk.org
Thu Apr 17 15:07:16 UTC 2025


On Thu, 17 Apr 2025 14:54:37 GMT, Mark Sheppard <msheppar at openjdk.org> wrote:

>> Ivan Šipka has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - removing accidentally added files, reverting to two test cases bu removing @ignores directive and adding test ids
>>  - copyright update
>
> test/jdk/java/nio/MappedByteBuffer/PmemTest.java line 87:
> 
>> 85:  */
>> 86: 
>> 87: /* @test id=other_architectures_test_case
> 
> we should to leave the @ignores for the 2nd test case 
> the test will be run on amd64 environmenst , as such the addition of  | (os.arch == "amd64") to the first test case  is fine

so just to confirm: we explitcitly want to ignore this test on `linux-aarch64` and `linux-ppc64le` regardless of is the required hardware present or not?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24416#discussion_r2049152149


More information about the nio-dev mailing list