RFR: 8351851: Update PmemTest to run on AMD64 [v2]
Mark Sheppard
msheppar at openjdk.org
Thu Apr 17 15:20:43 UTC 2025
On Thu, 17 Apr 2025 15:04:05 GMT, Ivan Šipka <isipka at openjdk.org> wrote:
>> test/jdk/java/nio/MappedByteBuffer/PmemTest.java line 87:
>>
>>> 85: */
>>> 86:
>>> 87: /* @test id=other_architectures_test_case
>>
>> we should to leave the @ignores for the 2nd test case
>> the test will be run on amd64 environmenst , as such the addition of | (os.arch == "amd64") to the first test case is fine
>
> so just to confirm: we explitcitly want to ignore this test on `linux-aarch64` and `linux-ppc64le` regardless of is the required hardware present or not?
yes, retain the @ignore in the second test case.
The original aim of this issue is to change the default test case of os.arch == "x86_64" to os.arch == "amd64" as the test will by default be run in an amd64 environment.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24416#discussion_r2049180807
More information about the nio-dev
mailing list